linux-kernel - Re: [RFC v5 00/26] Re-use nvram module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1508171756180.626@nippy.intranet>
Date:	Mon, 17 Aug 2015 18:04:59 +1000 (AEST)
From:	Finn Thain <fthain@...egraphics.com.au>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-m68k <linux-m68k@...r.kernel.org>,
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [RFC v5 00/26] Re-use nvram module

On Sun, 16 Aug 2015, Geert Uytterhoeven wrote:

> Hi Finn,
> 
> On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain <fthain@...egraphics.com.au> 
> wrote:
> > The generic NVRAM module, drivers/char/generic_nvram, implements a 
> > /dev/nvram misc device. It is used only by 32-bit PowerPC platforms 
> > and isn't generic enough to be more widely used.
> 
> [...]
> 
> Thanks!
> 
> You can add my
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> to patches 03, 04, 11, 19, 23, 24, 25, 26.

Thanks for reviewing.

> 
> BTW, checkpatch reported a few newly-introduced whitespace errors in 
> patches 03, 05, 16, 24, and 25.

I will check again, but I'm sure those are all deliberate. I examined all 
the "errors" and "warnings" before submitting.

checkpatch doesn't really understand the difference between whitespace 
used for indentation of statements (according to scope) and whitespace 
used for alignment of terms or parameters (when line-wrapped). Any tool 
that fails to make that distinction can't be depended upon to correctly 
validate the elisp in Documentation/CodingStyle, for example.

-- 

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/