linux-kernel - Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com>
Date:	Mon, 17 Aug 2015 15:04:16 +0300
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Huaitong Han <huaitong.han@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	Huaitong Han <huaitong.han@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, mingo@...hat.com,
	acme@...nel.org
Subject: Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning

Huaitong Han <huaitong.han@...el.com> writes:

> rdmsrl_safe does not lead to #GP in native kernel although CPU
> does not support INTEL_PT, but if KVM does not support INTEL_PT,
> the codes cannot understand MSR_IA32_RTIT_CTL, and the warning
> is produced.

"the codes"?

> If KVM does not support INTEL_PT, its guest CPUID also does not.
> So test_cpu_cap is added before RDMSR, and it is more in line with
> the code style.

It does make more sense like this, but please improve this commit
message. And don't forget to include Peter in the loop.

FWIW,

Reviewed-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/