linux-kernel - [PATCH] writeback: account BDI's min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Aug 2015 23:45:53 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Akinobu Mita <akinobu.mita@...il.com>, Tejun Heo <tj@...nel.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: [PATCH] writeback: account BDI's min_ratio for unregistered device

>From mm/page-writeback.c:

	/*
	 * bdi_min_ratio keeps the sum of the minimum dirty shares of all
	 * registered backing devices, which, for obvious reasons, can not
	 * exceed 100%.
	 */
	static unsigned int bdi_min_ratio;

But when a backing device is unregistered, the BDI's min_ratio is not
subtracted from bdi_min_ratio.  So the second attempt to set min_ratio
in the following commands will fail.

	# modprobe null_blk
	# echo 50 > /sys/block/nullb0/bdi/min_ratio
	# modprobe -r null_blk
	# modprobe null_blk
	# echo 50 > /sys/block/nullb0/bdi/min_ratio

Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
Cc: Tejun Heo <tj@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>
---
 mm/backing-dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 42e0a63..92eefe3 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -849,6 +849,7 @@ void bdi_destroy(struct backing_dev_info *bdi)
 	}
 
 	wb_exit(&bdi->wb);
+	bdi_set_min_ratio(bdi, 0);
 }
 EXPORT_SYMBOL(bdi_destroy);
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/