lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Aug 2015 11:39:03 -0400 From: Peter Hurley <peter@...leysoftware.com> To: Michal Simek <michal.simek@...inx.com> CC: linux-kernel@...r.kernel.org, monstr@...str.eu, Anirudha Sarangi <anirudha.sarangi@...inx.com>, Sören Brinkmann <soren.brinkmann@...inx.com>, Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity On 08/17/2015 03:22 AM, Michal Simek wrote: > From: Anirudha Sarangi <anirudha.sarangi@...inx.com> > > Existing set_termios does not handle the option for enabling > odd parity. This patch fixes it. NAK. PARODD does not enable parity generation or detection. Regards, Peter Hurley > Signed-off-by: Anirudha Sarangi <anirudh@...inx.com> > Signed-off-by: Michal Simek <michal.simek@...inx.com> > --- > > drivers/tty/serial/xilinx_uartps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 009e0dbc12d2..a3020344ac9d 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -723,7 +723,7 @@ static void cdns_uart_set_termios(struct uart_port *port, > else > cval |= CDNS_UART_MR_STOPMODE_1_BIT; /* 1 STOP bit */ > > - if (termios->c_cflag & PARENB) { > + if ((termios->c_cflag & PARENB) || (termios->c_cflag & PARODD)) { > /* Mark or Space parity */ > if (termios->c_cflag & CMSPAR) { > if (termios->c_cflag & PARODD) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists