linux-kernel - Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55D20CD6.90709@roeck-us.net>
Date:	Mon, 17 Aug 2015 09:33:26 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap()
 errors

On 08/17/2015 09:19 AM, Bjorn Andersson wrote:
> syscon_node_to_regmap() returns a regmap or an ERR_PTR().
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/at91rm9200_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
> index 9ba1153465ae..e12a797cb820 100644
> --- a/drivers/watchdog/at91rm9200_wdt.c
> +++ b/drivers/watchdog/at91rm9200_wdt.c
> @@ -244,7 +244,7 @@ static int at91wdt_probe(struct platform_device *pdev)
>   	}
>
>   	regmap_st = syscon_node_to_regmap(parent->of_node);
> -	if (!regmap_st)
> +	if (IS_ERR(regmap_st))
>   		return -ENODEV;
>
>   	res = misc_register(&at91wdt_miscdev);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/