linux-kernel - Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150817172623.GO10748@sirena.org.uk>
Date:	Mon, 17 Aug 2015 10:26:23 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Peter Chen <peter.chen@...escale.com>
Cc:	Baolin Wang <baolin.wang@...aro.org>, balbi@...com,
	linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, sojka@...ica.cz,
	stern@...land.harvard.edu, r.baldyga@...sung.com,
	yoshihiro.shimoda.uh@...esas.com, linux-usb@...r.kernel.org,
	device-mainlining@...ts.linuxfoundation.org, sre@...nel.org,
	dbaryshkov@...il.com, dwmw2@...radead.org, sameo@...ux.intel.com,
	lee.jones@...aro.org, patches@...nsource.wolfsonmicro.com,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current
 limit management

On Mon, Aug 17, 2015 at 09:07:08AM +0800, Peter Chen wrote:
> On Fri, Aug 14, 2015 at 05:47:46PM +0800, Baolin Wang wrote:

> > +	1500,
> > +	1800,
> > +	550,
> > +};

> Why 550 is the last, but not 1800?

You'd have to ask the hardware engineers who designed the chip.  I
suspect it's because 550 was added at a late stage in the design process
but I'm basically just guessing there.

> >   *********************************************************************/
> > @@ -606,8 +646,31 @@ static int wm831x_power_probe(struct platform_device *pdev)
> >  		}
> >  	}

> > +	if (wm831x_pdata && wm831x_pdata->usb_gadget) {

> Where the wm831x_pdata->usb_gadget is initialized?

It's platform data, it will be initialised by whatever registers the
platform data.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)