linux-kernel - Re: [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Aug 2015 20:01:22 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Philipp Hachtmann <hachti@...hti.de>, johan@...nel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port_data

On Mon, Aug 17, 2015 at 09:06:15AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 17, 2015 at 05:31:46PM +0200, Philipp Hachtmann wrote:
> > The driver used usb_get_serial_data(port->serial) which compiled but resulted
> > in a NULL pointer being returned (and subsequently used). I did not go deeper
> > into this but I guess this is a regression.
> > 
> > Signed-off-by: Philipp Hachtmann <hachti@...hti.de>
> > ---
> >  drivers/usb/serial/symbolserial.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Doh, obviously no one has used this driver in a long time, thanks for
> these patches...

Wow...

> Johan, mind if I take these directly?

Please do.

This one should be tagged:

Fixes: a85796ee5149 ("USB: symbolserial: move private-data allocation to
port_probe")
Cc: stable <stable@...r.kernel.org>	# v3.10

And for both patches:

Acked-by: Johan Hovold <johan@...nel.org>

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/