linux-kernel - Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9DBF9CCE-196E-43FB-BA76-BFB4B5F47A22@mniewoehner.de>
Date:	Mon, 17 Aug 2015 20:51:14 +0200
From:	Michael Niewoehner <linux@...ewoehner.de>
To:	Heiko Stuebner <heiko@...ech.de>
Cc:	mturquette@...libre.com, sboyd@...eaurora.org,
	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linus.walleij@...aro.org
Subject: Re: [PATCH] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Hi Heiko,

I merged yours and mine :-)


pclk_cpu needs to keep running because it is needed for devices like
the act8865 regulator but with the recent gpio clock handling this is
not always the case anymore. So add it to the list of critical clocks.

Signed-off-by: Michael Niewoehner <linux@...ewoehner.de>
---
drivers/clk/rockchip/clk-rk3188.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c
index e4f9d47..1c93229 100644
--- a/drivers/clk/rockchip/clk-rk3188.c
+++ b/drivers/clk/rockchip/clk-rk3188.c
@@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
	"aclk_cpu",
	"aclk_peri",
	"hclk_peri",
+	"pclk_cpu",
};

static void __init rk3188_common_clk_init(struct device_node *np)
-- 
2.5.0





Am 17.08.2015 um 20:01 schrieb Heiko Stuebner <heiko@...ech.de>:

> Hi,
> 
> Am Montag, 17. August 2015, 19:38:22 schrieb Michael Niewoehner:
>> gpio clock is getting disabled to save power but pclk_cpu is needed for
>> act8865 regulator
> 
> Please refine the commit message a bit :-) . Something along
> 
> pclk_cpu needs to keep running and with the recent gpio clock
> handling this is not always the case anymore. So add it to the list
> of critical clocks.
> 
> 
> and also please add "Linus Walleij <linus.walleij@...aro.org>" to the list of 
> recipients. As the gpio clock handling change does go through his tree, the 
> matching critical clock handling should also go through him.
> 
> 
> Heiko
> 
>> 
>> Signed-off-by: Michael Niewoehner <linux@...ewoehner.de>
>> ---
>> drivers/clk/rockchip/clk-rk3188.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/clk/rockchip/clk-rk3188.c
>> b/drivers/clk/rockchip/clk-rk3188.c index e4f9d47..1c93229 100644
>> --- a/drivers/clk/rockchip/clk-rk3188.c
>> +++ b/drivers/clk/rockchip/clk-rk3188.c
>> @@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]
>> __initconst = { "aclk_cpu",
>> 	"aclk_peri",
>> 	"hclk_peri",
>> +	"pclk_cpu",
>> };
>> 
>> static void __init rk3188_common_clk_init(struct device_node *np)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/