linux-kernel - Re: [PATCH] mm/memblock: check memblock_reserve on fail in memblock_virt_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150817145932.68fe9460c4392a0c3907392a@linux-foundation.org>
Date:	Mon, 17 Aug 2015 14:59:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Tony Luck <tony.luck@...el.com>, Pekka Enberg <penberg@...nel.org>,
	Mel Gorman <mgorman@...e.de>, Robin Holt <holt@....com>,
	Tang Chen <tangchen@...fujitsu.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@...com>
Subject: Re: [PATCH] mm/memblock: check memblock_reserve on fail in
 memblock_virt_alloc_internal

On Sun, 16 Aug 2015 00:26:46 +0600 Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> This patch adds a check for memblock_reserve() call in the
> memblock_virt_alloc_internal() function, because memblock_reserve()
> can return -errno on fail.
> 
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1298,7 +1298,9 @@ again:
>  
>  	return NULL;
>  done:
> -	memblock_reserve(alloc, size);
> +	if (memblock_reserve(alloc, size))
> +		return NULL;
> +
>  	ptr = phys_to_virt(alloc);
>  	memset(ptr, 0, size);

This shouldn't ever happen.  If it *does* happen, something is messed
up and we should warn.  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/