linux-kernel - Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 14:43:00 +0300
From:	Mathias Nyman <mathias.nyman@...el.com>
To:	Roger Quadros <rogerq@...com>
CC:	balbi@...com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start

On 18.08.2015 13:39, Roger Quadros wrote:
> For whatever reason if XHCI died in the previous instant
> then it will never recover on the next xhci_start unless we
> clear the DYING flag.
>
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>   drivers/usb/host/xhci.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index f998ddf..d5f44b1 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -146,7 +146,8 @@ static int xhci_start(struct xhci_hcd *xhci)
>   				"waited %u microseconds.\n",
>   				XHCI_MAX_HALT_USEC);
>   	if (!ret)
> -		xhci->xhc_state &= ~XHCI_STATE_HALTED;
> +		xhci->xhc_state &= ~(XHCI_STATE_HALTED | XHCI_STATE_DYING);
> +
>   	return ret;
>   }
>
>

Thanks, applied

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/