[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BN3PR0101MB1057C3FE09F00EEC55D2C9B1D0780@BN3PR0101MB1057.prod.exchangelabs.com>
Date: Tue, 18 Aug 2015 16:45:44 +0000
From: Hartley Sweeten <HartleyS@...ionengravers.com>
To: Pratyush Anand <panand@...hat.com>,
"linux@...ck-us.net" <linux@...ck-us.net>
CC: Krzysztof Kozlowski <k.kozlowski@...sung.com>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@...nsource.wolfsonmicro.com>,
"open list:ARM/STI ARCHITECTURE" <kernel@...inux.com>,
Linus Walleij <linus.walleij@...aro.org>,
Baruch Siach <baruch@...s.co.il>,
"open list:INTEL MANAGEMENT ENGINE mei"
<linux-kernel@...r.kernel.org>, "Wim Van Sebroeck" <wim@...ana.be>,
Thierry Reding <thierry.reding@...il.com>,
Alexandre Courbot <gnurou@...il.com>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@...r.kernel.org>, Lee Jones <lee@...nel.org>,
Kukjin Kim <kgene@...nel.org>,
Tomas Winkler <tomas.winkler@...el.com>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
Stephen Warren <swarren@...dotorg.org>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@...ts.infradead.org>,
"open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
"moderated list:ARM/U300 MACHINE SUPPORT"
<linux-arm-kernel@...ts.infradead.org>,
Maxime Coquelin <maxime.coquelin@...com>,
Barry Song <baohua@...nel.org>,
Johannes Thumshirn <morbidrsa@...il.com>,
Support Opensource <support.opensource@...semi.com>,
Andreas Werner <andreas.werner@....de>,
Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
Patrice Chotard <patrice.chotard@...com>
Subject: RE: [PATCH V2] Watchdog: Fix parent of watchdog_devices
On Tuesday, August 18, 2015 9:34 AM, Pratyush Anand wrote:
>
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set
> its parent and so, we do not see an entry for device in sysfs for such devices.
>
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
>
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.
>
> Signed-off-by: Pratyush Anand <panand@...hat.com>
> ---
[snip]
drivers/watchdog/ep93xx_wdt.c | 1 +
[snip]
diff --git a/drivers/watchdog/ep93xx_wdt.c b/drivers/watchdog/ep93xx_wdt.c
index 7a2cc7191c58..0a4d7cc05d54 100644
--- a/drivers/watchdog/ep93xx_wdt.c
+++ b/drivers/watchdog/ep93xx_wdt.c
@@ -132,6 +132,7 @@ static int ep93xx_wdt_probe(struct platform_device *pdev)
val = readl(mmio_base + EP93XX_WATCHDOG);
ep93xx_wdt_wdd.bootstatus = (val & 0x01) ? WDIOF_CARDRESET : 0;
ep93xx_wdt_wdd.timeout = timeout;
+ ep93xx_wdt_wdd.parent = &pdev->dev;
watchdog_set_nowayout(&ep93xx_wdt_wdd, nowayout);
For ep93xx_wdt.c, use whichever tag you prefer:
Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
Acked-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
Thanks,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists