linux-kernel - Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <30CDC3A0-82AB-4B87-BFF9-D8D645334830@redhat.com>
Date:	Tue, 18 Aug 2015 10:34:00 +0800
From:	"Yan, Zheng" <zyan@...hat.com>
To:	Brad Hubbard <bhubbard@...hat.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, sage@...hat.com
Subject: Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings


> On Aug 17, 2015, at 09:05, Brad Hubbard <bhubbard@...hat.com> wrote:
> 
>    ceph: remove redundant test of head->safe and silence static analysis warnings
> 
>    Signed-off-by: Brad Hubbard <bhubbard@...hat.com>
> ---
> fs/ceph/mds_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 6aa07af..6e196ee 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)
>                mutex_unlock(&mdsc->mutex);
>                goto out;
>        }
> -       if (req->r_got_safe && !head->safe) {
> +       if (req->r_got_safe) {
>                pr_warn("got unsafe after safe on %llu from mds%d\n",
>                           tid, mds);
>                mutex_unlock(&mdsc->mutex);
> -- 

added to our testing branch,

Thanks
Yan, Zheng--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/