linux-kernel - Re: [GIT PULL for v4.2] media fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFzNkvRYbhfiwOOC+_okHKN+Hf93bTF0fpiEqn6fYtLmEw@mail.gmail.com>
Date:	Tue, 18 Aug 2015 16:54:13 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL for v4.2] media fixes

On Tue, Aug 18, 2015 at 1:18 PM, Mauro Carvalho Chehab
<mchehab@....samsung.com> wrote:
>
>         - Revert the IR encode patches, as the API is not mature enough.
>           So, better to postpone the changes to a latter Kernel;

What the hell have you done with the commit messages?

The first line is completely corrupted for those reverts, and as a
result your own shortlog looks like crap and is completely misleading.

A revert is described as

     Revert ".. old patch name goes here .."

but your reverts are broken, and are described as

    .. old patch name goes here .."

presumably due to some horribly broken automation crap of yours that
adds the "[media]" prefix or something.

How did you not notice this when you sent the shortlog? Or even
earlier? This is some serious sh*t, since it basically means that your
log messages are very misleading, since the one-liner actually implies
exactly the reverse of what the commit does.

I unpulled this, because I think misleading commit messages is a
serious problem, and basically *half* (and patch-wise, the bulk) of
the commits in this queue are completely broken.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/