linux-kernel - Re: [PATCH v3 25/51] PCI: Fix size calculation with old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150818040943.GV26431@google.com>
Date:	Mon, 17 Aug 2015 23:09:43 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Wei Yang <weiyang@...ux.vnet.ibm.com>, TJ <linux@....tj>,
	Yijing Wang <wangyijing@...wei.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 25/51] PCI: Fix size calculation with old_size on
 rescan path

On Mon, Jul 27, 2015 at 04:29:43PM -0700, Yinghai Lu wrote:
> On booting path, we don't pass realloc at first, and treat all optional just
> as must, in some case we can smaller size/align with optional than must only.
> 
> 04:00.0 has four child bridges: 05:01.0, 05:02.0, 05:03.0, 05:04.0
> pref layout after booting path like followings:
> 
> pci 0000:04:00.0: BAR 9: assigned [mem 0x84000000-0x9fffffff 64bit pref]
> pci 0000:05:04.0: BAR 9: assigned [mem 0x88000000-0x9fffffff 64bit pref]
> pci 0000:05:03.0: BAR 9: assigned [mem 0x84000000-0x841fffff 64bit pref]
> pci 0000:07:00.0: BAR 0: assigned [mem 0x81200000-0x8123ffff 64bit]
> pci 0000:05:03.0: PCI bridge to [bus 08-0f]
> pci 0000:05:03.0:   bridge window [mem 0x84000000-0x841fffff 64bit pref]
> pci 0000:10:00.0: BAR 0: assigned [mem 0x90000000-0x9fffffff 64bit pref]
> pci 0000:10:00.0: BAR 2: assigned [mem 0x88000000-0x8800ffff 64bit pref]
> pci 0000:05:04.0: PCI bridge to [bus 10]
> pci 0000:05:04.0:   bridge window [mem 0x88000000-0x9fffffff 64bit pref]
> pci 0000:04:00.0: PCI bridge to [bus 05-10]
> pci 0000:04:00.0:   bridge window [mem 0x84000000-0x9fffffff 64bit pref]

Unless 07:00.0 and 10:00.0 are relevant, please remove them.

> so the old size in rescan for 04:00.0 would be 0x1c000000, and align is 0x4000000
> 
> during remove and rescan:
> 
> pci 0000:05:03.0: bridge window [mem 0x00000000-0xffffffffffffffff 64bit pref] to [bus 08-0f] add_size 200000 add_align 100000 alt_size 0 alt_align 0 must_size 0 must_align 0

What is "[mem 0x00000000-0xffffffffffffffff 64bit pref]" telling us?
Surely that's not an actual aperture, is it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/