linux-kernel - Re: [PATCH 07/20] staging: rtl8192u: r8192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150818052417.GD2941@sudip-pc>
Date:	Tue, 18 Aug 2015 10:54:17 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Raphaël Beamonte <raphael.beamonte@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Greg Donald <gdonald@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>
Subject: Re: [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening

On Sat, Aug 15, 2015 at 09:34:03PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte <raphael.beamonte@...il.com>
> ---
<snip>
> @@ -2182,30 +2182,30 @@ static void rtl8192_init_priv_variable(struct net_device *dev)
>  	priv->EarlyRxThreshold = 7;
>  	priv->enable_gpio0 = 0;
>  	priv->TransmitConfig =
> -		(TCR_MXDMA_2048<<TCR_MXDMA_OFFSET) |  // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
> -		(priv->ShortRetryLimit<<TCR_SRL_OFFSET) |	// Short retry limit
> -		(priv->LongRetryLimit<<TCR_LRL_OFFSET) |	// Long retry limit
> +		(TCR_MXDMA_2048 << TCR_MXDMA_OFFSET) |  // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
> +		(priv->ShortRetryLimit << TCR_SRL_OFFSET) |       // Short retry limit
> +		(priv->LongRetryLimit << TCR_LRL_OFFSET) |        // Long retry limit
>  		(false ? TCR_SAT : 0);	// FALSE: HW provides PLCP length and LENGEXT, TRUE: SW provides them
>  #ifdef TO_DO_LIST
>  	if (Adapter->bInHctTest)
>  		pHalData->ReceiveConfig	=	pHalData->CSMethod |
> -						RCR_AMF | RCR_ADF |	//accept management/data
> +						RCR_AMF | RCR_ADF |     //accept management/data
>  						//guangan200710
> -						RCR_ACF |	//accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko.
> -						RCR_AB | RCR_AM | RCR_APM |		//accept BC/MC/UC
> -						RCR_AICV | RCR_ACRC32 |			//accept ICV/CRC error packet
> -						((u32)7<<RCR_MXDMA_OFFSET) | // Max DMA Burst Size per Rx DMA Burst, 7: unlimited.
> -						(pHalData->EarlyRxThreshold<<RCR_FIFO_OFFSET) | // Rx FIFO Threshold, 7: No Rx threshold.
> +						RCR_ACF |       //accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko.
> +						RCR_AB | RCR_AM | RCR_APM |             //accept BC/MC/UC
> +						RCR_AICV | RCR_ACRC32 |                 //accept ICV/CRC error packet
> +						((u32)7 << RCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
looks like the comment has changed. copy paste error from previous
lines?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/