linux-kernel - Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE_Gge0hoBesmz2m3wzkUOx5k+pWzmZVuFiXs2OiXaS+Op1wnw@mail.gmail.com>
Date:	Tue, 18 Aug 2015 01:38:21 -0400
From:	Raphaël Beamonte <raphael.beamonte@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Greg Donald <gdonald@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>
Subject: Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent
 spacing code style error

2015-08-18 1:02 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@...il.com>:
> since you are modifying these lines for consistent spacing, it will be
> better to have:
> (priv->ShortRetryLimit << TCR_SRL_OFFSET) |       // Short retry limit
<snip>
> This should be:
> priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >> 8;

Are you talking about spacing around the << and >> ?
If so, shouldn't that last line be:
priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID >> 1)) >> 8;

And should I thus apply that to the whole file?

Thanks!
Raphaël
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/