linux-kernel - Re: [PATCH V3] Watchdog: Fix parent of watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150819064419.GC9999@pengutronix.de>
Date:	Wed, 19 Aug 2015 08:44:19 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Pratyush Anand <panand@...hat.com>
Cc:	linux@...ck-us.net, Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"open list:WOLFSON MICROELECTRONICS DRIVERS" 
	<patches@...nsource.wolfsonmicro.com>,
	"open list:ARM/STI ARCHITECTURE" <kernel@...inux.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Baruch Siach <baruch@...s.co.il>,
	"open list:INTEL MANAGEMENT ENGINE mei" 
	<linux-kernel@...r.kernel.org>, Wim Van Sebroeck <wim@...ana.be>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
	<linux-samsung-soc@...r.kernel.org>, Lee Jones <lee@...nel.org>,
	Kukjin Kim <kgene@...nel.org>,
	Tomas Winkler <tomas.winkler@...el.com>,
	linux-watchdog@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>,
	"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@...ts.infradead.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
	"moderated list:ARM/U300 MACHINE SUPPORT" 
	<linux-arm-kernel@...ts.infradead.org>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Barry Song <baohua@...nel.org>,
	Johannes Thumshirn <morbidrsa@...il.com>,
	Support Opensource <support.opensource@...semi.com>,
	Andreas Werner <andreas.werner@....de>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Patrice Chotard <patrice.chotard@...com>,
	kbuild test robot <fengguang.wu@...el.com>
Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/