linux-kernel - Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150819085904.GF3258@linux>
Date:	Wed, 19 Aug 2015 14:29:04 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	ralf@...ux-mips.org
Cc:	linaro-kernel@...ts.linaro.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Hongliang Tao <taohl@...ote.com>,
	Huacai Chen <chenhc@...ote.com>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:MIPS" <linux-mips@...ux-mips.org>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	Valentin Rothberg <valentinrothberg@...il.com>
Subject: Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode'
 assignment

On 12-08-15, 15:48, Viresh Kumar wrote:
> On 06-08-15, 14:25, Viresh Kumar wrote:
> > This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
> > Migrate to new 'set-state' interface") commit, but it wasn't.
> > 
> > Remove it now.
> > 
> > Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > ---
> > Ralf:
> > 
> > Not sure how it was left out in my series, but I thought it should have
> > been caught by the compilers as the function hpet_set_mode doesn't exist
> > today.
> > 
> > Either merge it with the offending commit or keep it separate.
> > 
> >  arch/mips/loongson64/loongson-3/hpet.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
> > index 950096e8d7cd..bf9f1a77f0e5 100644
> > --- a/arch/mips/loongson64/loongson-3/hpet.c
> > +++ b/arch/mips/loongson64/loongson-3/hpet.c
> > @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
> >  	cd->name = "hpet";
> >  	cd->rating = 320;
> >  	cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
> > -	cd->set_mode = hpet_set_mode;
> >  	cd->set_state_shutdown = hpet_set_state_shutdown;
> >  	cd->set_state_periodic = hpet_set_state_periodic;
> >  	cd->set_state_oneshot = hpet_set_state_oneshot;
> 
> Ping

Another Ping !!

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/