lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 19 Aug 2015 08:06:56 +0530
From:	Vaishali Thakkar <vthakkar1994@...il.com>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: denali: Use module_pci_driver

On Wed, Aug 19, 2015 at 6:02 AM, Brian Norris
<computersforpeace@...il.com> wrote:
>
> On Tue, Jul 07, 2015 at 12:53:45PM +0530, Vaishali Thakkar wrote:
> > Use module_pci_driver for drivers whose init and exit functions
> > only register and unregister, respectively.
> >
> > A simplified version of the Coccinelle semantic patch that performs
> > this transformation is as follows:
> >
> > @a@
> > identifier f, x;
> > @@
> > -static f(...) { return pci_register_driver(&x); }
> >
> > @b depends on a@
> > identifier e, a.x;
> > @@
> > -static e(...) { pci_unregister_driver(&x); }
> >
> > @c depends on a && b@
> > identifier a.f;
> > declarer name module_init;
> > @@
> > -module_init(f);
> >
> > @d depends on a && b && c@
> > identifier b.e, a.x;
> > declarer name module_exit;
> > declarer name module_pci_driver;
> > @@
> > -module_exit(e);
> > +module_pci_driver(x);
> >
> > Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
>
> It seems I got 3 independent versions of the same patch... I pushed the
> most recent one, then noticed this one. Thanks anyway.

No problem. It's fine with me.

> Brian




-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists