linux-kernel - Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150819160433.GW13472@usrtlx11787.corpusers.net>
Date:	Wed, 19 Aug 2015 09:04:33 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Mark Brown <broonie@...nel.org>,
	Andy Gross <agross@...eaurora.org>,
	"Bird, Tim" <Tim.Bird@...ymobile.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo

On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote:

> Just setting fixed_uV is not enough, the regulator core will also check
> n_voltages setting. The fixed_uV only works when n_voltages is 1.
> 

Thanks, I missed that.

Reviewed-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/qcom_smd-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 9d093ae..9c6167d 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
>  
>  static const struct regulator_desc pm8941_lnldo = {
>  	.fixed_uV = 1740000,
> +	.n_voltages = 1,
>  	.ops = &rpm_smps_ldo_ops,
>  };
>  
> -- 
> 2.1.0
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/