linux-kernel - Re: [PATCH 2/6] dmaengine: mxs: support i.MX7D and deep sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150819164816.GI13546@localhost>
Date:	Wed, 19 Aug 2015 22:18:16 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Han Xu <b45815@...escale.com>
Cc:	dan.j.williams@...el.com, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] dmaengine: mxs: support i.MX7D and deep sleep mode

On Tue, Jul 28, 2015 at 12:49:13PM -0500, Han Xu wrote:
> From: Huang Shijie <b32955@...escale.com>
> 
> The patch support i.MX7D platform by adding extra DMA clock.
> 
> Deep Sleep Mode(dsm) turns off the power for APBH DMA module, add
> suspend/resume function and re-init the APBH DMA during resume.

I have only 2/6, whats going on?

> +static int mxs_dma_pm_suspend(struct device *dev)
> +{
> +	/*
> +	 * We do not save any registers here, since the gpmi will release its
> +	 * DMA channel.
> +	 */
> +	return 0;
> +}
Why do we need the empty fn?

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/