linux-kernel - [tip:irq/urgent] ARM: OMAP: wakeupgen: Restore the irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Aug 2015 16:22:38 -0700
From:	tip-bot for Grygorii Strashko <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	balbi@...com, grygorii.strashko@...com,
	linux-kernel@...r.kernel.org, tony@...mide.com,
	marc.zyngier@....com, linux-arm-kernel@...ts.infradead.org,
	hpa@...or.com, jason@...edaemon.net, sudeep.holla@....com,
	tglx@...utronix.de, linux@....linux.org.uk, mingo@...nel.org,
	nsekhar@...com
Subject: [tip:irq/urgent] ARM: OMAP: wakeupgen: Restore the irq_set_type()
  mechanism

Commit-ID:  63059a272398ef5dc1bd7065a036e8b6e82d1af7
Gitweb:     http://git.kernel.org/tip/63059a272398ef5dc1bd7065a036e8b6e82d1af7
Author:     Grygorii Strashko <grygorii.strashko@...com>
AuthorDate: Fri, 14 Aug 2015 15:20:28 +0300
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 20 Aug 2015 00:25:25 +0200

ARM: OMAP: wakeupgen: Restore the irq_set_type() mechanism

The conversion of the wakeupgen irqchip to hierarchical irq domains
failed to provide a mechanism to properly set the trigger type of an
interrupt.

The wakeupgen irq chip itself has no mechanism and therefor no
irq_set_type() callback. The code before the conversion relayed the
trigger configuration directly to the underlying GIC.

Restore the correct behaviour by setting the wakeupgen irq_set_type
callback to irq_chip_set_type_parent(). This propagates the
set_trigger() call to the underlying GIC irqchip.

[ tglx: Massaged changelog ]

Fixes: 7136d457f365 ('ARM: omap: convert wakeupgen to stacked domains')
Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
Acked-by: Tony Lindgren <tony@...mide.com>
Cc: Sudeep Holla <sudeep.holla@....com>
Cc: <linux@....linux.org.uk>
Cc: <nsekhar@...com>
Cc: <jason@...edaemon.net>
Cc: <balbi@...com>
Cc: <linux-arm-kernel@...ts.infradead.org>
Cc: <marc.zyngier@....com>
Cc: stable@...r.kernel.org # 4.1
Link: http://lkml.kernel.org/r/1439554830-19502-5-git-send-email-grygorii.strashko@ti.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/arm/mach-omap2/omap-wakeupgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index 8e52621..e1d2e99 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -392,6 +392,7 @@ static struct irq_chip wakeupgen_chip = {
 	.irq_mask		= wakeupgen_mask,
 	.irq_unmask		= wakeupgen_unmask,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/