linux-kernel - [tip:irq/urgent] irqchip/crossbar: Restore set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 19 Aug 2015 16:23:18 -0700
From:	tip-bot for Grygorii Strashko <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	jason@...edaemon.net, mingo@...nel.org, grygorii.strashko@...com,
	tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org,
	hpa@...or.com, nsekhar@...com, balbi@...com, tony@...mide.com,
	linux-kernel@...r.kernel.org, linux@....linux.org.uk,
	marc.zyngier@....com, sudeep.holla@....com
Subject: [tip:irq/urgent] irqchip/crossbar: Restore set_wake functionality

Commit-ID:  8200fe4347870d4ad6475048bcdf3e7c106c5268
Gitweb:     http://git.kernel.org/tip/8200fe4347870d4ad6475048bcdf3e7c106c5268
Author:     Grygorii Strashko <grygorii.strashko@...com>
AuthorDate: Fri, 14 Aug 2015 15:20:30 +0300
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 20 Aug 2015 00:25:26 +0200

irqchip/crossbar: Restore set_wake functionality

The TI crossbar irqchip doesn't provides any facility to configure the
wakeup sources, but the conversion to hierarchical irqdomains set the
irq_set_wake callback to irq_chip_set_wake_parent. The parent chip
(OMAP wakeupgen) has no irq_set_wake function either so the call will
fail with -ENOSYS. As a result the irq_set_wake() call in the resume
path will trigger an 'Unbalanced wake disable' warning.

Before the conversion the GIC irqchip was the top level irqchip and
correctly flagged with IRQCHIP_SKIP_SET_WAKE.

Restore the correct behaviour by removing the irq_set_type callback
from the crossbar irqchip and set the IRQCHIP_SKIP_SET_WAKE flag which
lets the irq_set_irq_wake() call from the driver succeed.

[ tglx: Massaged changelog ]

Fixes: 783d31863fb8 ('irqchip: crossbar: Convert dra7 crossbar...')
Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
Cc: Sudeep Holla <sudeep.holla@....com>
Cc: <linux@....linux.org.uk>
Cc: <nsekhar@...com>
Cc: <jason@...edaemon.net>
Cc: <balbi@...com>
Cc: <linux-arm-kernel@...ts.infradead.org>
Cc: <tony@...mide.com>
Cc: <marc.zyngier@....com>
Cc: stable@...r.kernel.org # 4.1
Link: http://lkml.kernel.org/r/1439554830-19502-7-git-send-email-grygorii.strashko@ti.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/irqchip/irq-crossbar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index f5a72cc..c12bb93 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -68,9 +68,9 @@ static struct irq_chip crossbar_chip = {
 	.irq_mask		= irq_chip_mask_parent,
 	.irq_unmask		= irq_chip_unmask_parent,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
-	.irq_set_wake		= irq_chip_set_wake_parent,
 	.irq_set_type		= irq_chip_set_type_parent,
-	.flags			= IRQCHIP_MASK_ON_SUSPEND,
+	.flags			= IRQCHIP_MASK_ON_SUSPEND |
+				  IRQCHIP_SKIP_SET_WAKE,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
 #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/