| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Aug 2015 15:12:01 +1000 From: Ian Munsie <imunsie@....ibm.com> To: Michael Ellerman <mpe@...erman.id.au> Cc: Matt Ochs <mrochs@...ibm.com>, linuxppc-dev <linuxppc-dev@...abs.org>, mikey <mikey@...ling.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] cxl: add set/get private data to context struct Excerpts from Michael Ellerman's message of 2015-08-19 14:49:30 +1000: > Do we really need the accessors? They don't buy anything I can see over just > using ctx->priv directly. The reasoning there is because we don't currently expose the contents of stuct cxl_context to afu drivers, rather they just treat it as an opaque type. We could potentially change this to expose the details, but there's a lot of junk in there that's just internal details of the cxl driver that isn't of interest to an afu driver that I'd rather not expose. We also already have another accessor function (cxl_process_element) in the api, so it's not out of place. FWIW I'm not opposed to changing how this api works if it ultimately makes things better, but I want to wait until the cxlflash superpipe support is merged so any patches that change the api can change it at the same time. Cheers, -Ian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists