linux-kernel - Re: un4i-ss-cipher.c warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150820063900.GJ30520@lukather>
Date:	Thu, 20 Aug 2015 08:39:00 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Michal Suchanek <hramrach@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Corentin Labbe <clabbe.montjoie@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: un4i-ss-cipher.c warning

On Thu, Aug 20, 2015 at 01:29:03PM +0800, Herbert Xu wrote:
> On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote:
> > Hello,
> > 
> > when building a kernel with sunxi crypto driver as merged into the
> > sinxi-wip branch I get a compiler warning.
> > 
> > I am not sure this is the latest version of the driver. It does not
> > seem to be in mainline yet.
> 
> The warning appears to be spurious as the code always ends up
> initialising todo before using it.

Not in the dev_dbg call line 258. If ileft was negative or null, todo
isn't assigned to anything.

I'm not sure whether initializing todo to 0 is the right thing to do
though. Corentin?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)