[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150820080547.GB30260@js1304-P5Q-DELUXE>
Date: Thu, 20 Aug 2015 17:05:48 +0900
From: Joonsoo Kim <iamjoonsoo.kim@....com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Minchan Kim <minchan@...nel.org>,
Nitin Gupta <ngupta@...are.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Stephan Mueller <smueller@...onox.de>
Subject: Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't
require tfm object
On Thu, Aug 20, 2015 at 03:50:35PM +0800, Herbert Xu wrote:
> On Thu, Aug 20, 2015 at 04:52:17PM +0900, Joonsoo Kim wrote:
> >
> > Hmm... I guess there is no problem. crypto_alg object fetched by
> > crypto_get_comp() introduced in this patch could be hardware device
> > algorithm which is same one that we can eventually fetch from tfm object.
> > So, this approach would correctly track the crypto_alg regardless
> > it is a hardware one or not. If there is some dependency between
> > algorithm and tfm, it can't support _noctx API. Am I missing
> > something?
>
> Your approach limits what hardware devices we can support in
> future. It is fairly common for hardware drivers to only allocate
> resources when a tfm is created. With your tfmless interface,
> the driver would have to unconditionally allocate resources.
Ah...Okay. thanks for clarifying.
>
> It is essentially a global tfm without the tfm.
>
> > Yes, I thought this way before, but, current way is much simpler so
> > I try it first. If it is not acceptable, I will implement this
> > approach.
>
> Please go with a global tfm.
Okay. Will do that in next spin.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists