linux-kernel - RE: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB804B6@AcuExch.aculab.com>
Date:	Thu, 20 Aug 2015 10:13:21 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	David Laight <David.Laight@...LAB.COM>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available
 again to non GPL modules

From: David Laight
> Sent: 05 August 2015 10:52
> To: linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules
> 
> > From:       Tejun Heo
> > Date:       2015-08-04 18:05:20
> > On Tue, Aug 04, 2015 at 11:26:04AM -0600, tim.gardner@...onical.com wrote:
> > > From: Tim Gardner <tim.gardner@...onical.com>
> > >
> > > Commit 37b1ef31a568fc02e53587620226e5f3c66454c8 ("workqueue: move
> > > flush_scheduled_work() to workqueue.h") moved the exported non GPL
> > > flush_scheduled_work() from a function to an inline wrapper.
> > > Unfortunately, it directly calls flush_workqueue() which is a GPL function.
> > > This has the effect of changing the licensing requirement for this function
> > > and makes it unavailable to non GPL modules.
> > >
> > > See commit ad7b1f841f8a54c6d61ff181451f55b68175e15a ("workqueue: Make
> > > schedule_work() available again to non GPL modules") for precedent.
> > >
> > > Cc: Tejun Heo <tj@...nel.org>
> > > Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> >
> > Applied to wq/for-4.3.
> 
> I hit this yesterday afternoon as well!
> 
> Can we get the fix into 4.2 itself ?

This doesn't seem to be in 4.2 yet.
It is an interface regression that will cause grief.

	David
(I'm not subscribed to linux-kernel, so copy me in any responses.)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/