[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55D5CB5F.2010106@xs4all.nl>
Date: Thu, 20 Aug 2015 14:43:11 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Javier Martinez Canillas <javier@....samsung.com>,
linux-kernel@...r.kernel.org
CC: Sören Brinkmann <soren.brinkmann@...inx.com>,
devel@...verdev.osuosl.org, Kukjin Kim <kgene@...nel.org>,
linux-sh@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@....samsung.com>,
Hyun Kwon <hyun.kwon@...inx.com>,
Hans Verkuil <hans.verkuil@...co.com>,
linux-samsung-soc@...r.kernel.org,
Kyungmin Park <kyungmin.park@...sung.com>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
"Prabhakar\"" <prabhakar.csengg@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Michal Simek <michal.simek@...inx.com>,
linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead
of .parent
On 08/19/15 17:35, Javier Martinez Canillas wrote:
> The struct media_entity has a .parent field that stores a pointer
> to the parent struct media_device. But recently a media_gobj was
> embedded into the entities and since struct media_gojb already has
> a pointer to a struct media_device in the .mdev field, the .parent
> field becomes redundant and can be removed.
>
> This patch replaces all the usage of .parent by .graph_obj.mdev so
> that field will become unused and can be removed on a later patch.
>
> No functional changes.
>
> The transformation was made using the following coccinelle spatch:
>
> @@
> struct media_entity *me;
> @@
>
> - me->parent
> + me->graph_obj.mdev
>
> @@
> struct media_entity *link;
> @@
>
> - link->source->entity->parent
> + link->source->entity->graph_obj.mdev
>
> @@
> struct exynos_video_entity *ve;
> @@
>
> - ve->vdev.entity.parent
> + ve->vdev.entity.graph_obj.mdev
>
> Suggested-by: Mauro Carvalho Chehab <mchehab@....samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
Acked-by: Hans Verkuil <hans.verkuil@...co.com>
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists