linux-kernel - Re: [PATCH] regulator: core: Use IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1600359.hvYhnkmyof@wuerfel>
Date:	Thu, 20 Aug 2015 15:26:41 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linaro-kernel@...ts.linaro.org
Cc:	Viresh Kumar <viresh.kumar@...aro.org>, broonie@...nel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: Use IS_ERR_OR_NULL()

On Monday 17 August 2015 12:30:58 Viresh Kumar wrote:
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 78387a6cbae5..55b49acfd9b3 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1595,7 +1595,7 @@ static void _regulator_put(struct regulator *regulator)
>  {
>         struct regulator_dev *rdev;
>  
> -       if (regulator == NULL || IS_ERR(regulator))
> +       if (IS_ERR_OR_NULL(regulator))
>                 return;

The use of IS_ERR_OR_NULL is almost always a bug (as is the open-coded
equivalent).
Please try to find out why this is done here and add a comment
if it's actually correct, or fix it if not.

My guess is that it is not ok to pass an error pointer as the argument
of _regulator_put(), so maybe there should be WARN_ON()?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/