linux-kernel - Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Aug 2015 23:38:47 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Alexander Kuleshov <kuleshovmail@...il.com>,
	Henrik Rydberg <rydberg@...math.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and
 debugfs_create_file()

Hello Jiri,

On 08-19-15, Jiri Kosina wrote:
> On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
> 
> >  
> > -	hid_debug_init();
> > +	if (hid_debug)
> > +		hid_debug_init();
> 
> How is this change related to the rest of the patch?
> 
> It's wrong anyway, because hid_debug is independent of the debugfs HID 
> debugging facility. Please see for example the printk() a few lines above 
> in this very function, which is emited in case hid_debug is enabled.
>

hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/