linux-kernel - Re: [PATCH v2 2/5] regmap: Fix regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150820182725.GJ12027@sirena.org.uk>
Date:	Thu, 20 Aug 2015 11:27:25 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kernel@...gutronix.de, Irina Tirdea <irina.tirdea@...el.com>,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes

On Thu, Aug 20, 2015 at 11:12:33AM +0200, Markus Pargmann wrote:

> +	} else if (map->use_single_rw) {
> +		/*
> +		 * We need to handle bus writes separate to support val_bytes
> +		 * that are not powers of 2.
> +		 */

This comment is really hard to understand - the condition block we're in
is nothing to do with the number of val_bytes and the comment is just
making a statement, there's no why in there.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)