linux-kernel - Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1508202157260.3873@nanos>
Date:	Thu, 20 Aug 2015 22:02:54 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Tim Chen <tim.c.chen@...ux.intel.com>
cc:	Borislav Petkov <bp@...e.de>, Dave Hansen <dave.hansen@...el.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Chandramouli Narayanan <mouli@...ux.intel.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, mouli_7982@...oo.com
Subject: Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions
 implementations

On Thu, 20 Aug 2015, Tim Chen wrote:
> From: Tim Chen <tim.c.chen@...ux.intel.com>
> Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

   sha: is not a proper subsystem name

   x86/cpufeatures: is the correct one

>  Enable cpuid check for Intel SHA extensions implementations

This patch does not enable any checks. It merily adds the feature bit.
 
> The Intel Secure Hash Algorithm Extensions are designed to improve the performance
> of SHA-1 and SHA-256. This patch adds the check for X86_FEATURE_SHA_NI bit.

Again there is no check.

> This will allow the feature to be shown in the /proc/cpuinfo.
> 
> The SHA extension programming guide is found in chapter 8 of the Intel
> Architecture Instruction Set Extensions Programming reference:
> https://software.intel.com/sites/default/files/managed/07/b7/319433-023.pdf
> 
> Originally-by: Chandramouli Narayanan <mouli@...ux.intel.com>

So Mouli left the company. What's the point of having his Intel mail
address here and in the Cc list?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/