linux-kernel - Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201508202352.22313.marex@denx.de>
Date:	Thu, 20 Aug 2015 23:52:22 +0200
From:	Marek Vasut <marex@...x.de>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Alexander Stein <alexander.stein@...tec-electronic.com>,
	linux-mtd@...ts.infradead.org, vndao@...era.com,
	dwmw2@...radead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, ngachi86@...il.com
Subject: Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

On Thursday, August 20, 2015 at 10:19:25 PM, Brian Norris wrote:
> On Thu, Aug 20, 2015 at 12:06:36PM +0200, Alexander Stein wrote:
> > On Thursday 20 August 2015 10:03:38, Marek Vasut wrote:
> > > > +Example:
> > > > +
> > > > +			quadspi_controller_0: quadspi@...80014a0 {
> > > > +				compatible = "altr,quadspi-1.0";
> > > > +				reg = <0x180014a0 0x00000020>,
> > > > +				      <0x14000000 0x04000000>;
> > > > +				reg-names = "avl_csr", "avl_mem";
> > > > +				#address-cells = <1>;
> > > > +				#size-cells = <0>;
> > > > +				flash0: epcq256@0 {
> > > > +					compatible = "altr,epcq256";
> > > > +					#address-cells = <1>;
> > > > +					#size-cells = <1>;
> > > > +					partition@0 {
> > > > +						/* 16 MB for raw data. 
*/
> > > > +						label = "EPCQ Flash 0 
raw data";
> > > > +						reg = <0x0 0x1000000>;
> > > > +					};
> > > > +					partition@...0000 {
> > > > +						/* 16 MB for jffs2 data. 
*/
> > > > +						label = "EPCQ Flash 0 
JFFS 2";
> > > > +						reg = <0x1000000 
0x1000000>;
> > > > +					};
> > > 
> > > IIRC, encoding partitions into OF is deprecated (and it shouldn't be
> > > part of the example anyway, so please remove this bit).
> > 
> > Do you mean specifying partitions in OF is deprecated in general? Is
> > there any link for that? What would be an alternative to it?
> 
> This is the first I've heard of such a deprecation. I would argue that
> it's still probably one of the best ways to specify partitions. It's not
> exactly perfect (partitions aren't really "hardware", so may not belong
> in the "hardware description")

Which is the reasoning why I heard it was deprecated, but it seems my
knowledge is not correct. I apologize for the misinformation, sorry.

> , but IMO it's better than cmdlineparts,
> for instance. I also don't really know of any good-enough, generically
> useful on-flash partition formats, especially ones that can handle the
> complexities of NAND.

Right.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/