lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150821110455.GW5558@mwanda>
Date:	Fri, 21 Aug 2015 14:04:55 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: Removed a space

On Thu, Aug 20, 2015 at 07:26:59PM +0530, Aparna Karuthodi wrote:
> Removed a space before parenthesis to remove a coding style error
> detected by checkpatch.
> The error is given below:
> drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
> that close parenthesis ')'
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/fbtft/fb_bd663474.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0x100, 0x7120 );
>  	write_reg(par, 0x007, 0x0103 );
>  	mdelay( 10 );
> -	write_reg(par, 0x007, 0x0113 );
> +	write_reg(par, 0x007, 0x0113);

Every other line in the surrounding context has the same issue.  Please
don't just change one line at a time like this...  It is a waste of our
time.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ