[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55D74A37.5020104@suse.com>
Date: Fri, 21 Aug 2015 08:56:39 -0700
From: Tony Jones <tonyj@...e.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>,
Vlastimil Babka <vbabka@...e.cz>
CC: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Mel Gorman <mgorman@...e.com>
Subject: Re: [PATCH v2] perf script/python: add new compaction-times script
On 08/20/2015 12:42 PM, Arnaldo Carvalho de Melo wrote:
> Well, we don't have any firm set standard for outputting from scripts,
> so if you did it inspired by existing scripts outputs, probably that is
> good enough, having someone testing it is a plus, and in these cases, if
> the "works for me" means you actually tested it, can we replace the
> "Acked-by" with a "Tested-by"?
The output seemed consistent with the existing scripts in that, as you point out, there really isn't much consistency. Taking a second look, the only thing I can see is that scripts such as futex-contention and failed-syscalls-by-pid output "comm *[pid]" whereas I'm outputting "pid[comm]". That's certainly easy to change.
Yes, I believe Vlastimil tested v1 and v2 but I'll let him speak to this and to whether his approval goes beyond testing (re: acked-by).
thanks
tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists