linux-kernel - RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE6401CB0067B@SHSMSX101.ccr.corp.intel.com>
Date:	Fri, 21 Aug 2015 16:24:44 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Nigel Cunningham <nigel@...elcunningham.com.au>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"pavel@....cz" <pavel@....cz>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>
CC:	"Zhang, Rui" <rui.zhang@...el.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for
 suspend

Hi, Nigel

> -----Original Message-----
> From: Nigel Cunningham [mailto:nigel@...elcunningham.com.au]
> Sent: Friday, August 21, 2015 8:35 PM
> To: Chen, Yu C; rjw@...ysocki.net; pavel@....cz; tglx@...utronix.de;
> mingo@...hat.com; hpa@...or.com
> Cc: Zhang, Rui; lenb@...nel.org; x86@...nel.org; linux-pm@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for
> suspend
> 
> Hi Chen.
> 
> Is there any issue with saving and restoring MSRs unconditionally? That
> would simplify the patch and make things 'just work'.
Saving/restoring unconditionally might take BIOS legal action into account,
for example, BIOS itself is willing to modify the MSR.  And Pavel suggests
using quirk to workaround in V1 patch:
https://patchwork.kernel.org/patch/7023891/

So I'm considering a common framework to save/restore these MSRs,
because user might need to protect more than one MSR during 
suspend, so..

I can modify this patch to a simpler version, for example,
Introducing two variables in struct saved_context , like
MSR_IA32_MISC_ENABLE does.

Thanks for your review

Best Regards,
Yu
> 
> Regards,
> 
> Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/