linux-kernel - Re: [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150821170353.GB26236@localhost>
Date:	Fri, 21 Aug 2015 10:03:53 -0700
From:	Olof Johansson <olof@...om.net>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org,
	Gwendal Grignou <gwendal@...omium.org>,
	Doug Anderson <dianders@...omium.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead
 CROS_EC_PROTO

On Wed, Aug 19, 2015 at 01:19:55PM +0200, Javier Martinez Canillas wrote:
> The ChromeOS EC LPC and chardev drivers depend on CROS_EC_PROTO but
> MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
> 
> Since the platform devices that are matched with these drivers are
> registered by the ChromeOS EC mfd driver, they really depend on
> MFD_CROS_EC. And because this config option selects CROS_EC_PROTO,
> that dependency is met as well. So make the drivers to depend on
> MFD_CROS_EC instead of CROS_EC_PROTO.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>


Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/