linux-kernel - Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLr59L+1fi0UDjQPVmEOUbT-KnmpLY562mACHxsRqHEk3A@mail.gmail.com>
Date:	Fri, 21 Aug 2015 15:19:18 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Leonidas S Barbosa <leosilva@...ux.vnet.ibm.com>
Cc:	linux-crypto@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	LKML <linux-kernel@...r.kernel.org>,
	Paulo Smorigo <pfsmorigo@...ux.vnet.ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug

On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa
<leosilva@...ux.vnet.ibm.com> wrote:
> AES-CTR is using a counter 8bytes-8bytes what miss match with
> kernel specs.
>
> In the previous code a vadduwm was done to increment counter.
> Replacing this for a vadduqm now considering both cases counter
> 8-8 bytes and full 16bytes.

Seems this breaks ppc allmodconfig:

drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm'

1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 is the first bad commit
commit 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0
Author: Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>
Date:   Fri Aug 14 10:12:22 2015 -0300

    crypto: vmx - Fixing AES-CTR counter bug


   http://kisskb.ellerman.id.au/kisskb/buildresult/12490159/


Paul.
--

>
> Signed-off-by: Leonidas S Barbosa <leosilva@...ux.vnet.ibm.com>
> ---
>  drivers/crypto/vmx/aes_ctr.c    |  8 +++++++-
>  drivers/crypto/vmx/aesp8-ppc.pl | 34 +++++++++++++++++-----------------
>  2 files changed, 24 insertions(+), 18 deletions(-)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/