linux-kernel - Re: [PATCH] staging: fbtft: Made into two lines

Open Source and information security mailing list archives

Date:	Sun, 23 Aug 2015 10:52:38 +0300
From:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	noralf@...nnes.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/fbtft/fb_pcd8544.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index 8b9ebfb..cf87ce8 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,7 +34,8 @@
>  #define WIDTH          84
>  #define HEIGHT         48
>  #define TXBUFLEN       (84*6)
> -#define DEFAULT_GAMMA  "40" /* gamma is used to control contrast in this driver */
> +#define DEFAULT_GAMMA  "40"
> +/* gamma is used to control contrast in this driver */

I think the format is usually:
/* comment */
#define FOO BAR

>  
>  static unsigned tc;
>  module_param(tc, uint, 0);
> -- 
> 1.7.9.5
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives