linux-kernel - Re: [PATCH] x86/calling.h: remove unused SAVE_ALL/RESTORE_ALL macro for !CONFIG_x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Aug 2015 05:09:20 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Alexander Kuleshov" <kuleshovmail@...il.com>
Cc:	"Andy Lutomirski" <luto@...capital.net>, <x86@...nel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Denys Vlasenko" <dvlasenk@...hat.com>,
	"Ingo Molnar" <mingo@...hat.com>, <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86/calling.h: remove unused SAVE_ALL/RESTORE_ALL
 macro for !CONFIG_x86_64

>>> On 21.08.15 at 21:12, <kuleshovmail@...il.com> wrote:
> SAVE_ALL and RESTORE_ALL macros for !CONFIG_X86_64 were introduced in the
> 1a338ac32 commit (sched, x86: Optimize the preempt_schedule() call) and
> were used in the ___preempt_schedule and ___preempt_schedule_context from
> the  arch/x86/kernel/preempt.S. But the arch/x86/kernel/preempt.S was
> removed in the 0ad6e3c5 commit (x86: Speed up ___preempt_schedule*() by
> using THUNK helpers) and ___preempt_schedule/___preempt_schedule_context
> are reimplemeted and not used SAVE_ALL/RESTORE_ALL anymore.
> 
> These macros have no users anymore, so we can remove it.

As far as the description goes this is fine, but ...

> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -46,8 +46,6 @@ For 32-bit we have the following conventions - kernel is built with
>  
>  */
>  
> -#ifdef CONFIG_X86_64

... why do you remove this conditional, thus exposing x86-64-only
definitions to ix86 code?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/