[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150824114901.GC3237@x1>
Date: Mon, 24 Aug 2015 12:49:01 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Javier Martinez Canillas <javier@....samsung.com>
Cc: devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/4] mfd: Add DT binding for Maxim MAX77802 IC
On Mon, 24 Aug 2015, Javier Martinez Canillas wrote:
> The MAX77802 is a chip that contains regulators, 2 32kHz clocks,
> a RTC and an I2C interface to program the individual components.
>
> The are already DT bindings for the regulators and clocks and
> these reference to a bindings/mfd/max77802.txt file, that didn't
> exist, for the details about the PMIC.
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>
> ---
>
> Changes in v4:
> - Reword section about max77802 clock and regulator DT binding docs.
> Suggested by Lee Jones.
> - Align max77802 mfd required properties. Suggested by Lee Jones.
>
> Changes in v3:
> - Add Krzysztof Kozlowski Reviewed-by tag to patch #3.
> - Capitalise all acronyms. Suggested by Lee Jones.
> - Use relative path to refer other bindings. Suggested by Lee Jones.
> - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones.
>
> Changes in v2:
> - Use the correct "maxim,max77802" compatible string.
> Suggested by Krzysztof Kozlowski
> - Use a pmic generic node name for the max77802 node example.
> Suggested by Sergei Shtylyov.
>
> Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
Applied, thanks.
> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
> new file mode 100644
> index 000000000000..51fc1a60caa5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max77802.txt
> @@ -0,0 +1,26 @@
> +Maxim MAX77802 multi-function device
> +
> +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
> +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
> +up application processors and peripherals, a 2-channel 32kHz clock outputs,
> +a Real-Time-Clock (RTC) and a I2C interface to program the individual
> +regulators, clocks outputs and the RTC.
> +
> +Bindings for the built-in 32k clock generator block and
> +regulators are defined in ../clk/maxim,max77802.txt and
> +../regulator/max77802.txt respectively.
> +
> +Required properties:
> +- compatible : Must be "maxim,max77802"
> +- reg : Specifies the I2C slave address of PMIC block.
> +- interrupts : I2C device IRQ line connected to the main SoC.
> +- interrupt-parent : The parent interrupt controller.
> +
> +Example:
> +
> + max77802: pmic@09 {
> + compatible = "maxim,max77802";
> + interrupt-parent = <&intc>;
> + interrupts = <26 IRQ_TYPE_NONE>;
> + reg = <0x09>;
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists