linux-kernel - Re: [PATCH v3 4/6] ARCv2: perf: implement exclusion of event counting in user or kernel mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DB487E.5020409@synopsys.com>
Date:	Mon, 24 Aug 2015 22:08:22 +0530
From:	Vineet Gupta <vgupta@...opsys.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arc-linux-dev@...opsys.com" <arc-linux-dev@...opsys.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH v3 4/6] ARCv2: perf: implement exclusion of event counting
 in user or kernel mode

On Monday 24 August 2015 08:00 PM, Vineet Gupta wrote:
> On Monday 24 August 2015 07:50 PM, Alexey Brodkin wrote:
>> > Cc: Peter Zijlstra <peterz@...radead.org>
>> > Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
>> > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
>> > ---
>> >
>> > No changes since v2.
>> >
>> > No changes since v1.
>> >
>> > ....
>> >  	}
>> >  
>> > +	hwc->config = 0;
>> > +
>> > +	if (is_isa_arcv2()) {
>> > +		/* "exclude user" means "count only kernel" */
>> > +		if (event->attr.exclude_user)
>> > +			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
>> > +
>> > +		/* "exclude kernel" means "count only user" */
>> > +		if (event->attr.exclude_kernel)
>> > +			hwc->config |= ARC_REG_PCT_CONFIG_USER;
>> > +	}
>> > +
>> >  	switch (event->attr.type) {
>> >  	case PERF_TYPE_HARDWARE:
>> >  		if (event->attr.config >= PERF_COUNT_HW_MAX)
>> >  			return -ENOENT;
>> >  		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
>> >  			return -ENOENT;
>> > -		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
>> > +		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];
> With raw events patch dropped - this hunk need not be present.

Please ignore this stupid comment - this was written when I was presumably smoking
pot !

> 
>> >  		pr_debug("init event %d with h/w %d \'%s\'\n",
>> >  			 (int) event->attr.config, (int) hwc->config,
>> >  			 arc_pmu_ev_hw_map[event->attr.config]);
>> > @@ -163,7 +175,7 @@ static int arc_pmu_event_init(struct perf_event *event)
>> >  		ret = arc_pmu_cache_event(event->attr.config);
>> >  		if (ret < 0)
>> >  			return ret;
>> > -		hwc->config = arc_pmu->ev_hw_idx[ret];
>> > +		hwc->config |= arc_pmu->ev_hw_idx[ret];
>> >  		return 0;
>> >  	default:
>> >  		return -ENOENT;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/