linux-kernel - Re: [PATCH] nfit, nd_blk: BLK status register is only 32 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150824174042.GA18754@linux.intel.com>
Date:	Mon, 24 Aug 2015 11:40:42 -0600
From:	Ross Zwisler <ross.zwisler@...ux.intel.com>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-nvdimm@...1.01.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	linux-acpi@...r.kernel.org, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] nfit, nd_blk: BLK status register is only 32 bits

On Mon, Aug 24, 2015 at 01:02:17PM -0400, Jeff Moyer wrote:
> Ross Zwisler <ross.zwisler@...ux.intel.com> writes:
> 
> > Only read 32 bits for the BLK status register in read_blk_stat().
> >
> > The format and size of this register is defined in the
> > "NVDIMM Driver Writer's guide":
> >
> > http://pmem.io/documents/NVDIMM_Driver_Writers_Guide.pdf
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> > Reported-by: Nicholas Moulin <nicholas.w.moulin@...ux.intel.com>
> 
> Looks fine,
> 
> Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
> 
> However, now that you've drawn attention to that code, I'll note that
> there is no checking of the pending or retry bits.  In fact,
> ACPI_NFIT_CONTROL_BUFFERED isn't even checked upon loading the tables.
> Is this on a todo list somewhere?

Yep, you're right, we do need to add support for each of these.  I'm planning
on doing it unless someone else gets to it first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/