lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150824190803.GA19781@ghost>
Date:	Mon, 24 Aug 2015 22:08:04 +0300
From:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	noralf@...nnes.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?

Resubmit it properly with "PATCH v2" in the title and a good commit message.

> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/fbtft/fb_pcd8544.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
>  #define WIDTH          84
>  #define HEIGHT         48
>  #define TXBUFLEN       (84*6)
> -#define DEFAULT_GAMMA  "40"
>  /* gamma is used to control contrast in this driver */

Isn't this comment supposed to be on the previous line (the removed line)?
Check if you haven't messed this up

> +#define DEFAULT_GAMMA  "40"
>  
>  static unsigned tc;
>  module_param(tc, uint, 0);
> -- 
> 1.7.9.5
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ