linux-kernel - [PATCH 00/10] mm: fix instances of non-modular code using modular fcns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Aug 2015 18:14:32 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Andrey Konovalov <adech.fo@...il.com>,
	Andrey Ryabinin <a.ryabinin@...sung.com>,
	Christoph Lameter <cl@...ux.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	David Rientjes <rientjes@...gle.com>,
	Hillf Danton <hillf.zj@...baba-inc.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>,
	Mike Kravetz <mike.kravetz@...cle.com>,
	Minchan Kim <minchan@...nel.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Pekka Enberg <penberg@...nel.org>,
	Rob Jones <rob.jones@...ethink.co.uk>,
	Roman Pen <r.peniaev@...il.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Toshi Kani <toshi.kani@...com>,
	Vladimir Davydov <vdavydov@...allels.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	WANG Chao <chaowang@...hat.com>
Subject: [PATCH 00/10] mm: fix instances of non-modular code using modular fcns

In the previous merge window, we made changes to allow better
delineation between modular and non-modular code in commit
0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init
from init.h to module.h").  This allows us to now ensure module code
looks modular and non-modular code does not accidentally look modular
without suffering build breakage from header entanglement.

Here we target mm code that is, by nature of their Kconfig/Makefile, only
available to be built-in, but implicitly presenting itself as being
possibly modular by way of using modular headers and macros.

The goal here is to remove that illusion of modularity from these
files, but in a way that leaves the actual runtime unchanged.
We also get the side benefit of a reduced CPP overhead, since the
removal of module.h from a file can reduce the number of lines emitted
by 20k.

In all but the hugetlb change, the change is the trivial remapping
of module_init onto device_initcall -- which is what module_init 
becomes in the non-modular case.  In the hugetlb case, there was also
an unused/orphaned module_exit chunk of code that got removed.

I considered using an alternate level (i.e. earlier) initcall but
since we don't have an mm initcall category, there wasn't a clear
choice.  And staying with device initcall reduces this patch series
to zero risk by keeping the status quo on init order processing, which
is I think preferable as we approach the merge window in a week.

Paul.
---

Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andrey Konovalov <adech.fo@...il.com>
Cc: Andrey Ryabinin <a.ryabinin@...sung.com>
Cc: Christoph Lameter <cl@...ux.com>
Cc: Davidlohr Bueso <dave@...olabs.net>
Cc: David Rientjes <rientjes@...gle.com>
Cc: Hillf Danton <hillf.zj@...baba-inc.com>
Cc: Johannes Weiner <hannes@...xchg.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc: Mel Gorman <mgorman@...e.de>
Cc: Michal Hocko <mhocko@...e.cz>
Cc: Mike Kravetz <mike.kravetz@...cle.com>
Cc: Minchan Kim <minchan@...nel.org>
Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc: Pekka Enberg <penberg@...nel.org>
Cc: Rob Jones <rob.jones@...ethink.co.uk>
Cc: Roman Pen <r.peniaev@...il.com>
Cc: Sasha Levin <sasha.levin@...cle.com>
Cc: Toshi Kani <toshi.kani@...com>
Cc: Vladimir Davydov <vdavydov@...allels.com>
Cc: Vlastimil Babka <vbabka@...e.cz>
Cc: WANG Chao <chaowang@...hat.com>
Cc: linux-mm@...ck.org

Paul Gortmaker (10):
  mm: make cleancache.c explicitly non-modular
  mm: make slab_common.c explicitly non-modular
  mm: make hugetlb.c explicitly non-modular
  mm: make vmscan.c explicitly non-modular
  mm: make page_alloc.c explicitly non-modular
  mm: make vmstat.c explicitly non-modular
  mm: make workingset.c explicitly non-modular
  mm: make vmalloc.c explicitly non-modular
  mm: make frontswap.c explicitly non-modular
  mm: make kasan.c explicitly non-modular

 mm/cleancache.c  |  4 ++--
 mm/frontswap.c   |  5 ++---
 mm/hugetlb.c     | 39 +--------------------------------------
 mm/kasan/kasan.c |  4 +---
 mm/page_alloc.c  |  2 +-
 mm/slab_common.c |  4 ++--
 mm/vmalloc.c     |  4 ++--
 mm/vmscan.c      |  4 +---
 mm/vmstat.c      |  7 +++----
 mm/workingset.c  |  4 ++--
 10 files changed, 17 insertions(+), 60 deletions(-)

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/