[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075CFB85748@IN01WEMBXB.internal.synopsys.com>
Date: Tue, 25 Aug 2015 07:47:44 +0000
From: Vineet Gupta <Vineet.Gupta1@...opsys.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
Yuriy Kolerov <yuriy.kolerov@...opsys.com>,
Tomi Valkeinen <tomi.valkeinen@...com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Linux-Arch <linux-arch@...r.kernel.org>,
Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
"Anton.Kolesov@...opsys.com" <Anton.Kolesov@...opsys.com>,
Francois Bedard <Francois.Bedard@...opsys.com>
Subject: Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE
On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote:
> On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov
> <yuriy.kolerov@...opsys.com> wrote:
>> Architectures which support VGA console must define screen_info
>> structurture from "uapi/linux/screen_info.h". Otherwise undefined
>> symbol error occurs. Usually it's defined in "setup.c" for each
>> architecture.
>>
>> If an architecture does not support VGA console (ARC's case)
>> there are 2 ways: define a dummy instance of screen_info or add
>> a negative dependency for VGA_CONSOLE in to prevent selecting
>> this option.
>>
>> I've implemented the second way. However the best solution is to
>> add HAVE_VGA_CONSOLE option for targets which support VGA
>> console. Then turn off VGA_CONSOLE by default and add dependency
>> to HAVE_VGA_CONSOLE. But right now it's better to just add a
>> negative dependency for ARC and then consider how to collaborate
>> about this issue with maintainers of other architectures.
> +1
>
>> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@...opsys.com>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Hi Tomi,
Is anything else needed for this to be merged.
Thx,
-Vineet
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists