lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2015 14:11:53 +0530 From: Vaibhav Hiremath <vaibhav.hiremath@...aro.org> To: Lee Jones <lee.jones@...aro.org> CC: linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, mturquette@...libre.com, k.kozlowski@...sung.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > >> Driver had coding style issues where spaces were used instead >> of tabs. This patch fixes them all. > > That's not all it's doing though is it? > Yes, its just tabbing related fixes. > Please describe all of your changes. > >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@...aro.org> >> --- >> drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++-------------------------- >> 1 file changed, 61 insertions(+), 64 deletions(-) >> >> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c >> index f104a32..c4e097d 100644 >> --- a/drivers/mfd/88pm800.c >> +++ b/drivers/mfd/88pm800.c >> @@ -30,55 +30,55 @@ >> #include <linux/of_device.h> >> >> /* Interrupt Registers */ >> -#define PM800_INT_STATUS1 (0x05) >> +#define PM800_INT_STATUS1 0x05 >> #define PM800_ONKEY_INT_STS1 (1 << 0) >> #define PM800_EXTON_INT_STS1 (1 << 1) >> -#define PM800_CHG_INT_STS1 (1 << 2) >> -#define PM800_BAT_INT_STS1 (1 << 3) >> -#define PM800_RTC_INT_STS1 (1 << 4) >> +#define PM800_CHG_INT_STS1 (1 << 2) >> +#define PM800_BAT_INT_STS1 (1 << 3) >> +#define PM800_RTC_INT_STS1 (1 << 4) >> #define PM800_CLASSD_OC_INT_STS1 (1 << 5) > > These should all be replaced by BIT(). > > Please fix the whole file. Will do. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists