| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2015 14:20:21 +0530 From: Vaibhav Hiremath <vaibhav.hiremath@...aro.org> To: Lee Jones <lee.jones@...aro.org> CC: linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, mturquette@...libre.com, k.kozlowski@...sung.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > >> Driver had coding style issues where spaces were used instead >> of tabs. This patch fixes them all. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@...aro.org> >> --- >> drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++-------------------------- >> 1 file changed, 61 insertions(+), 64 deletions(-) > > Same comment as before. > > How similar is this file to the other one? I believe you are referring to include/linux/mfd/88pm80x.h > > Can you reduce the size by having shared register defines? > Not sure whether I understand your comment here, They are common defines. PM860 only defines are named as PM860_XXXX Similarly, PM805 only defines are named as PM805_XXXX and PM800_xxx should be common. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists