linux-kernel - Re: [PATCH 01/10] mm: make cleancache.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F91A372A-4443-41C6-880F-5F6B66990FFA@oracle.com>
Date:	Mon, 24 Aug 2015 20:10:03 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] mm: make cleancache.c explicitly non-modular

On August 24, 2015 6:14:33 PM EDT, Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
>The Kconfig currently controlling compilation of this code is:
>
>config CLEANCACHE
>bool "Enable cleancache driver to cache clean pages if tmem is present"
>
>...meaning that it currently is not being built as a module by anyone.

Why not make it a tristate?


>
>Lets remove the couple traces of modularity so that when reading the
>driver there is no doubt it is builtin-only.
>
>Since module_init translates to device_initcall in the non-modular
>case, the init ordering remains unchanged with this commit.
>
>Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>Cc: linux-mm@...ck.org
>Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
>---
> mm/cleancache.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mm/cleancache.c b/mm/cleancache.c
>index 8fc50811119b..ee0646d1c2fa 100644
>--- a/mm/cleancache.c
>+++ b/mm/cleancache.c
>@@ -11,7 +11,7 @@
>  * This work is licensed under the terms of the GNU GPL, version 2.
>  */
> 
>-#include <linux/module.h>
>+#include <linux/init.h>
> #include <linux/fs.h>
> #include <linux/exportfs.h>
> #include <linux/mm.h>
>@@ -316,4 +316,4 @@ static int __init init_cleancache(void)
> #endif
> 	return 0;
> }
>-module_init(init_cleancache)
>+device_initcall(init_cleancache)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/