linux-kernel - Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 14:04:25 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>,
	Scott Branden <sbranden@...adcom.com>,
	Weijun Yang <Weijun.Yang@....com>,
	Andrew Bresticker <abrestic@...omium.org>,
	Jean Delvare <jdelvare@...e.de>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	addy ke <addy.ke@...k-chips.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	Kevin Hao <haokexin@...il.com>,
	Vincent Yang <vincent.yang.fujitsu@...il.com>
Subject: Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI

On 6 August 2015 at 07:39, Michal Simek <michal.simek@...inx.com> wrote:
> Add GPIOLIB dependency for MMC_SDHCI.
>
> Problem was observed after adding the patch
> "mmc: sdhci-of-arasan: Call OF parsing for MMC"
> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls
> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which
> calls devm_gpiod_get_index() which returns -ENOSYS.
>
> Error log:
> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258)
> sdhci-arasan: probe of ff160000.sdhci failed with error -38
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
> After RFC here https://lkml.org/lkml/2015/7/24/371
> adding dependency on MMC_SDHCI.
>
> ---
>  drivers/mmc/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index fd9a58e216a5..5519803c124b 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -38,6 +38,7 @@ config MMC_PXA
>  config MMC_SDHCI
>         tristate "Secure Digital Host Controller Interface support"
>         depends on HAS_DMA
> +       depends on GPIOLIB
>         help
>           This selects the generic Secure Digital Host Controller Interface.
>           It is used by manufacturers such as Texas Instruments(R), Ricoh(R)
> --
> 2.3.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/